Наследование классов - вычисление скользящих средних значений котировок

#include <iostream>
#include <fstream> // for open and read file
#include <vector> // for use vector STL
#include <map> // for use map STL
#include "quotes.h"
#include "moving_average.h"
#include "macd.h"
 
std::string for_start(std::string*, int);
bool check (std::string &, std::string *, int);
inline void star(){std::cout<<"\n";for (int i=0;i<80;i++){std::cout<<"*";}}
 
int main(){
 
   std:: string array_quotes[] =  {"GBPUSD","EURUSD","GOLDUSD"};//if you need a new qoute add here
   int size_of_str = sizeof(array_quotes)/sizeof(array_quotes[0]); /* i do it couse have problem with (sizeof(str)/sizeof(str[0])) in func. it retun 0*/
 
   std::map<const std::string, int>for_case;
   for_case["1"]=1;
   for_case["1.1"]=11;
   for_case["2"]=2;
   for_case["2.1"]=21;
 
   std:: string instr = for_start(array_quotes,size_of_str);
   std:: string choise;
   std:: string array_choise[] = {"1","1.1","2","2,1"};
 
   int size_of_choise = sizeof(array_quotes)/sizeof(array_quotes[0]);
 
   while (!check(choise,array_choise,size_of_choise)){
       std::cout<<"Whould you like to see quotes or take some analysis:\n";
       std::cout<<"1 - To see quotes(all quotes we have in our base)\n";
       std::cout<<" 1.1 - To see some period or date (for date just input nothing for end)\n";//
       std::cout<<"2 - Take some analysis( macd + moviend average)\n";
       std::cout<<" 2.1 - Take some analysis for some period\n";
       getline(std::cin,choise);
 
   }
 
   star();
 
   switch(for_case[choise])
   {
   case (1):
       {quotes obj1(instr);//need use {} in case if use variable
       obj1.show_quotes();
       break;}
   case (11):
       {quotes obj1(instr);
       obj1.show_quotes(true);
       break;}
   case (2):
       {
        moving_average obj1();
       break;
       }
   case (21):
       {
 
       break;
       }
   }
 
    std::cin.get();
    return 0;
}
 
bool check (std::string &answer, std::string *str, int SIZE){
   for ( int i = 0; i < SIZE;++i){
        if (str[i] == answer){
            return true;
        }
    }
   std::cout<<"you should choise only i have in my base please.\n";
   return false;
}
 
std::string for_start(std::string *array_quotes, int SIZE){
    std::string txt_begin = "/home/dima/QT_CPP/quotes/"; // change the directory if use in another dir
    std::string txt_end = ".txt";
    /*i use txt_begin and txt_end for write full adress for file*/
    std::string answer;
    while (!check(answer,array_quotes,SIZE)){
       std::cout<<"what instrument you are look for? in my base we are have:\n";
       for (int i = 0; i < SIZE;++i){
           std::cout<<array_quotes[i]<<", ";
       }
       star();
       //std::cout<<"\n";
       std::getline(std::cin,answer);
    }
    txt_begin.append(answer);
    txt_begin.append(txt_end);
    return txt_begin;
}

//use doble guard pragma and ifndef
#pragma once
#ifndef QUOTES_H
#define QUOTES_H
#include<iostream>
#include <vector>
#include <string>
 
class quotes {
    private:
    struct my_struct {
        double open,close,high,low;
        std::string date;
    }my_quotes_struct;
    std::vector<my_struct>my_quotes;
 
    public:
    quotes();//i need it for subclasses is not it? (derived classes)
    quotes(std::string&); // constructor with paramerts
    void pars_file(std::string &);// pars file
    void show_quotes();
    void show_quotes(bool);//overload show_quotes
    bool check_period (std::string&,std::string&,int &,int&);
    inline void star(){std::cout<<"\n";for (int i=0;i<80;i++){std::cout<<"*";}}
    ~quotes();//i needn't use it couse i don't use dinamic memmory
};
 
#endif //QUOTES_H

#include "quotes.h"
#include <fstream>//use it for open and read and write in file
#include <iostream>
#include <cstring> // for use substr
#include <cstdlib> //for use atof
#include <iomanip> // for use setw
 
quotes::quotes(std::string& value){
    std::string str;
    std::ifstream file;
    file.open(value.c_str());//try to open file. we need use c_str() couse in standart open take char* but not std::string
    if (!file){
        std::cout<<"somthing wrong chek file's name and restart program\n";
    } else {
        while (file){//while not end of file or we can use file_open.good() or file_open
            file>>str;
            pars_file(str);
        }
    }
    my_quotes.pop_back();//need delite last element of my vector array couse last element write uncorrect
    file.close();
}
 
quotes::~quotes(){};
 
void quotes::pars_file(std::string &str){
   /* catch expression trully i don't see any oversize in my substr construction my catch is crutch*/
   try {
   /* here is i dont want to write some one method for my class and write it's ritgh here*/
    my_quotes_struct.date = str.substr(0,10);//substr method for string
    str = str.substr(17);//do it couse i needn't time data
    my_quotes_struct.open = atof(str.substr(0,str.find(',')).c_str());
    //use atof for take double from char*. but i try use c++ type string that's whay i use c_str();
    str = str.substr(str.find(',')+1);
    my_quotes_struct.close = atof(str.substr(0,str.find(',')).c_str());
    str = str.substr(str.find(',')+1);
    my_quotes_struct.high = atof(str.substr(0,str.find(',')).c_str());
    str = str.substr(str.find(',')+1);
    my_quotes_struct.low = atof(str.substr(0,str.find(',')).c_str());
    }
    catch (const std::exception& out_of_range ) {
    //do nothing
          }
    my_quotes.push_back(my_quotes_struct);
  //std::cout<<my_quotes_struct.date<<" "<<my_quotes_struct.open<<" "<<my_quotes_struct.close<<" "<<my_quotes_struct.high<<" "<<my_quotes_struct.low<<"\n";
}
 
void quotes::show_quotes(){
    if (my_quotes.empty()){ //check vector for emptry. i hope it's will never empty
        std::cout<<"We have some problem, sorre, please restart programm";
    }else {
      for (unsigned int i=0;i<my_quotes.size();++i) {
          std::cout<<std::setw(6)<<my_quotes[i].date<<std::left<<" ";
          std::cout<<std::setw(6)<<my_quotes[i].open<<std::left<<" ";
          std::cout<<std::setw(6)<<my_quotes[i].close<<std::left<<" ";
          std::cout<<std::setw(6)<<my_quotes[i].high<<std::left<<" ";
          std::cout<<std::setw(6)<<my_quotes[i].low<<std::left<<"\n";
      }
    }
}
 
void quotes::show_quotes(bool){
    int begin_index, end_index;
    std::string begin,end;
    std::cout<<"We have quotes from "<<my_quotes[0].date<<" to "
    <<my_quotes[my_quotes.size()-1].date<<
    " to select period set begin and end of period\n";
    while(!check_period(begin,end,begin_index,end_index)) {
        std::cout<<"Please set the date of begin: \n";
        getline(std::cin,begin);
        std::cout<<"Please set the date of end: \n";
        getline(std::cin,end);
    }
    star();
 
    std::cout<<std::setw(10)<<"date"<<std::left<<" ";
    std::cout<<std::setw(6)<<"open"<<std::left<<" ";
    std::cout<<std::setw(6)<<"close"<<std::left<<" ";
    std::cout<<std::setw(6)<<"high"<<std::left<<" ";
    std::cout<<std::setw(6)<<"low"<<std::left<<"\n";
 
    for(int i = begin_index; i<= end_index;i++){
        std::cout<<std::setw(6)<<my_quotes[i].date<<std::left<<" ";
        std::cout<<std::setw(6)<<my_quotes[i].open<<std::left<<" ";
        std::cout<<std::setw(6)<<my_quotes[i].close<<std::left<<" ";
        std::cout<<std::setw(6)<<my_quotes[i].high<<std::left<<" ";
        std::cout<<std::setw(6)<<my_quotes[i].low<<std::left<<"\n";
    }
 
 
}
 
bool quotes::check_period(std::string&begin,std::string&end,int &begin_index, int & end_index){
    bool start;
    bool the_end;
    for(unsigned int i = 0;i<my_quotes.size();++i){
        if (begin == my_quotes[i].date){
            begin_index = i;
            start = true;
            break;
        }
    }
    for(unsigned int i = 0;i<my_quotes.size();++i){
        if (end == my_quotes[i].date || end == ""){//if we want take some date press enter for have no end of period
            end_index = i;
            the_end = true;
            break;
        }
    }
    if(start && the_end){
        return true;
    }else {
        return false;
    }
}

#ifndef MOVING_AVERAGE_H
#define MOVING_AVERAGE_H
#include "quotes.h"
 
 
class moving_average:public quotes{
    private:
    float slow_ma;
    float fast_ma;
 
    public:
    moving_average(int,int,std::string&);
 
};
 
#endif // MOVING_AVERAGE_H

#include "moving_average.h"
 
moving_average::moving_average(int s_ma,int f_ma,std::string&value){
    quotes::quotes(std::string&value);
 
}