На собеседовании попросили сделать код ревью

class ShopifyAPIClient
  attr_reader :shop_id
  SECRET_API_KEY = "asdasdasQWRESFSDFVSDFASDFSADFASDF123123ASDASD$%$%"
   
  def set_shop_id(shop_Id)
    @shop_id = shop_Id
  end
  
  def orders
    params = Hash.new
    params[:basic_auth] = {username: SECRET_API_KEY, password: ''}
    orders_json = some_http_library.get("https://www.shopify.this.is.a.sample.com/#{shop_id}/orders", params)
    return JSON.parse(orders_json)
  end
  
  def products
    params = Hash.new
    params[:basic_auth] = {username: SECRET_API_KEY, password: ''}
    products_json = some_http_library.get("https://www.shopify.this.is.a.sample.com/#{shop_id}/products", params)
    return JSON.parse(products_json)
  end
  
  def product(id)
    params = Hash.new
    params[:basic_auth] = {username: SECRET_API_KEY, password: ''}
    product_json = some_http_library.get("https://www.shopify.this.is.a.sample.com/#{shop_id}/products/#{id}", params)
    return JSON.parse(product_json)
  end
end

class ShopifyAPIClient
  attr_accessor :shop_id
  attr_accessor :shop_url
 
  def self.api_method(*method_names)
    return if method_names.empty?
 
    method_names.each do |method_name|
      define_method(method_name) do |*args|
        addr = ''
        addr << shop_url
        addr << shop_id.to_s << '/' << method_name.to_s
        addr << '/' << args[0].to_s unless args.empty?
        return addr
      end
    end
  end
 
  api_method :orders, :products
  api_method :product, :one_more_method
end
 
client = ShopifyAPIClient.new
client.shop_url = 'https://www.shopify.this.is.a.sample.com/'
client.shop_id = 5
 
puts client.orders
#=> [url]https://www.shopify.this.is.a.sample.com/5/orders[/url]
 
puts client.products
#=> [url]https://www.shopify.this.is.a.sample.com/5/products[/url]
 
client.shop_id = 3
client.shop_url = 'https://www.shopify.this.is.another.sample.com/'
 
puts client.product 15
#=> [url]https://www.shopify.this.is.another.sample.com/3/product/15[/url]
 
puts client.one_more_method
#=> [url]https://www.shopify.this.is.another.sample.com/3/one_more_method[/url]

class ShopifyAPIClient
  attr_accessor :shop_id
  attr_accessor :shop_url
 
  def initialize()
    @allowed_methods = [:orders, :products, :product, :one_more_method]
  end
 
  def method_missing(name, *args)
    raise NoMethodError, "undefined method `#{name}' for #{self}" unless @allowed_methods.include? name
    
    "#{shop_url}#{shop_id}/#{name}" + (args.empty? ? '' : "/#{args[0]}")
  end
 
end

  super unless @allowed_methods.include? name